Fixes #221 - Use nextPageToken to list all snapshots #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 18, 2017
| api_method = @compute.snapshots.list | ||
| project = @project if project.nil? | ||
| parameters = { | ||
| "project" => project | ||
| "project" => project, |
There was a problem hiding this comment.
Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
| data = service.list_snapshots(nil, next_page_token) | ||
| items.concat(data.body["items"]) | ||
| next_page_token = data.body['nextPageToken'] | ||
| end until next_page_token.nil? || next_page_token.empty? |
There was a problem hiding this comment.
Use Kernel#loop with break rather than begin/end/until(or while).
| begin | ||
| data = service.list_snapshots(nil, next_page_token) | ||
| items.concat(data.body["items"]) | ||
| next_page_token = data.body['nextPageToken'] |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
icco
approved these changes
May 23, 2017
|
Seems straight forward! Thanks @imriz! |
agrare
added a commit
to agrare/manageiq-providers-google
that referenced
this pull request
Jun 2, 2017
PR fog/fog-google#222 broke snapshot listing in our vcr cassettes which was released in 0.5.3. Lock down fog-google to 0.5.2 until we re-record the cassette.
This was referenced Jun 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.